Page MenuHomePhabricator

Freeze "maniphest.gettasktransactions" and make status/priority transactions more consistent
ClosedPublic

Authored by epriestley on Nov 22 2017, 2:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:50 PM
Unknown Object (File)
Sun, Dec 15, 4:47 PM
Unknown Object (File)
Wed, Dec 11, 9:19 AM
Unknown Object (File)
Mon, Dec 9, 5:13 PM
Unknown Object (File)
Mon, Dec 9, 5:13 PM
Unknown Object (File)
Mon, Dec 9, 5:12 PM
Unknown Object (File)
Mon, Dec 9, 5:07 PM
Unknown Object (File)
Mon, Dec 9, 2:47 AM
Subscribers
None

Details

Summary

Ref T13020. See PHI221.

Freeze legacy method maniphest.gettasktransactions in favor of modern method transaction.search.

Remove legacy "null on create" behavior from Maniphest status and priority transactions. This behavior is obsolete with EditEngine, and leads to inconsistent transaction sets in the transaction record.

The desired behavior is that transactions which don't do anything (e.g., default value was not changed) don't appear in the transaction log.

Test Plan
  • Viewed API UI and saw maniphest.gettasktransactions marked as "Frozen".
  • Created a new task via web UI (without changing status/priority), queried transactions with maniphest.gettasktransacitons/transaction.search, no longer saw "null on create" no-op transactions in record.
    • Web UI is unchanged, since these transactions were hidden before and now do not exist.

Diff Detail

Repository
rP Phabricator
Branch
status1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18839
Build 25394: Run Core Tests
Build 25393: arc lint + arc unit