Page MenuHomePhabricator

Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline
ClosedPublic

Authored by epriestley on Nov 15 2017, 5:28 PM.
Tags
None
Referenced Files
F15409531: D18774.id45049.diff
Wed, Mar 19, 4:39 AM
F15408432: D18774.diff
Tue, Mar 18, 10:59 PM
F15386140: D18774.diff
Sat, Mar 15, 12:07 AM
Unknown Object (File)
Mon, Mar 3, 3:52 AM
Unknown Object (File)
Fri, Feb 28, 6:08 AM
Unknown Object (File)
Feb 19 2025, 10:27 PM
Unknown Object (File)
Feb 9 2025, 4:51 AM
Unknown Object (File)
Feb 8 2025, 8:42 PM
Subscribers
None

Details

Summary

See PHI180. Currently, if you begin creating or editing an inline and then swap display modes (for example, with "View Unified"), your edit is lost.

Persisting the editor state is complicated and this is very rare, so just prevent the action and warn the user instead.

Also make the warning persist for a little longer since a few of the messages, including this one, take a couple seconds to read now.

Test Plan
  • Edited a comment, tried to swap display modes, got a warning.
  • Swapped display modes normally with no comment being edited.

Diff Detail

Repository
rP Phabricator
Branch
change1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18832
Build 25384: Run Core Tests
Build 25383: arc lint + arc unit