Restore "Summary" and "Test Plan" to initial mail for non-draft configurations
ClosedPublic
Actions

Authored by epriestley on Nov 14 2017, 8:13 PM.

Details

Reviewers

Maniphest Tasks

T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential

Commits

rPc098aec66931: (stable) Restore "Summary" and "Test Plan" to initial mail for non-draft…
rP314e7266c3e5: Restore "Summary" and "Test Plan" to initial mail for non-draft configurations

Summary

See PHI210. Ref T2543. Currently, we don't set this flag if you have prototypes off and don't get any of the new draft stuff, so the mail drops some of the details it is supposed to have.

Test Plan

Disabled prototypes, created a revision, saw summary / test plan in the initial mail.

Diff Detail

Repository

rP Phabricator

Branch

draft1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18825
Build 25374: Run Core Tests
Build 25373: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 14 2017, 8:13 PM

Harbormaster completed remote builds in B18825: Diff 45043.Nov 14 2017, 8:14 PM

epriestley requested review of this revision.Nov 14 2017, 8:14 PM

epriestley edited the summary of this revision. (Show Details)Nov 14 2017, 8:15 PM

amckinley accepted this revision.Nov 14 2017, 8:15 PM

This revision is now accepted and ready to land.Nov 14 2017, 8:15 PM

epriestley added a child revision: D18772: Allow "arc diff --draft" to create revisions as drafts more forcefully.Nov 14 2017, 8:22 PM

Closed by commit rP314e7266c3e5: Restore "Summary" and "Test Plan" to initial mail for non-draft configurations (authored by epriestley). · Explain WhyNov 14 2017, 8:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

7 lines

Diff 45043

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Restore "Summary" and "Test Plan" to initial mail for non-draft configurationsClosedPublicActions