Page MenuHomePhabricator

Make `bin/storage dump` insert CREATE DATABASE and USE statements
ClosedPublic

Authored by epriestley on Oct 13 2017, 8:53 PM.
Tags
None
Referenced Files
F19905360: D18707.id44912.diff
Tue, Mar 31, 4:17 PM
F19898829: D18707.id44912.diff
Sun, Mar 29, 4:07 PM
F19830327: D18707.diff
Mar 10 2026, 12:18 PM
F19569424: D18707.id44912.diff
Jan 31 2026, 11:35 PM
F19070375: D18707.id.diff
Nov 30 2025, 4:31 PM
F19059199: D18707.diff
Nov 29 2025, 4:48 AM
F18843017: D18707.id44911.diff
Oct 28 2025, 8:27 PM
F18835471: D18707.id.diff
Oct 26 2025, 4:02 PM
Subscribers
None

Details

Summary

Ref T13000. The new approach for dumping database-by-database means that we don't get CREATE DATABASE or USE statements, which makes importing the dump again inconvenient.

Manually stitch these into the dump.

Test Plan
  • Used bin/storage dump --namespace ... to dump a smaller local instance.
  • Used bin/storage destroy --namespace ..., to destroy the namespace, then inported the dump cleanly.
  • Verified that each CREATE DATABASE statement appears only once.
  • Verified that bin/storage renamespace --live can correctly process this file.

Diff Detail

Repository
rP Phabricator
Branch
dump3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18686
Build 25174: Run Core Tests
Build 25173: arc lint + arc unit