Page MenuHomePhabricator

Make `bin/storage dump` insert CREATE DATABASE and USE statements
ClosedPublic

Authored by epriestley on Oct 13 2017, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 9, 2:47 PM
Unknown Object (File)
Oct 15 2024, 8:51 AM
Unknown Object (File)
Oct 14 2024, 12:18 AM
Unknown Object (File)
Oct 4 2024, 11:19 PM
Unknown Object (File)
Oct 4 2024, 11:18 PM
Unknown Object (File)
Oct 4 2024, 11:17 PM
Unknown Object (File)
Oct 4 2024, 11:12 PM
Unknown Object (File)
Oct 1 2024, 5:02 AM
Subscribers
None

Details

Summary

Ref T13000. The new approach for dumping database-by-database means that we don't get CREATE DATABASE or USE statements, which makes importing the dump again inconvenient.

Manually stitch these into the dump.

Test Plan
  • Used bin/storage dump --namespace ... to dump a smaller local instance.
  • Used bin/storage destroy --namespace ..., to destroy the namespace, then inported the dump cleanly.
  • Verified that each CREATE DATABASE statement appears only once.
  • Verified that bin/storage renamespace --live can correctly process this file.

Diff Detail

Repository
rP Phabricator
Branch
dump3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18686
Build 25174: Run Core Tests
Build 25173: arc lint + arc unit