Page MenuHomePhabricator

Make `bin/storage dump` insert CREATE DATABASE and USE statements
ClosedPublic

Authored by epriestley on Oct 13 2017, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 9:03 PM
Unknown Object (File)
Thu, Jan 23, 6:23 AM
Unknown Object (File)
Tue, Jan 21, 11:52 PM
Unknown Object (File)
Jan 5 2025, 2:14 PM
Unknown Object (File)
Jan 3 2025, 12:46 PM
Unknown Object (File)
Dec 28 2024, 4:46 PM
Unknown Object (File)
Dec 27 2024, 4:40 PM
Unknown Object (File)
Dec 21 2024, 6:07 PM
Subscribers
None

Details

Summary

Ref T13000. The new approach for dumping database-by-database means that we don't get CREATE DATABASE or USE statements, which makes importing the dump again inconvenient.

Manually stitch these into the dump.

Test Plan
  • Used bin/storage dump --namespace ... to dump a smaller local instance.
  • Used bin/storage destroy --namespace ..., to destroy the namespace, then inported the dump cleanly.
  • Verified that each CREATE DATABASE statement appears only once.
  • Verified that bin/storage renamespace --live can correctly process this file.

Diff Detail

Repository
rP Phabricator
Branch
dump3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18686
Build 25174: Run Core Tests
Build 25173: arc lint + arc unit