Page MenuHomePhabricator

Correct bad context path when doing pattern search inside a repository
ClosedPublic

Authored by epriestley on Sep 29 2017, 9:50 PM.
Tags
None
Referenced Files
F15395474: D18664.diff
Sun, Mar 16, 7:13 AM
Unknown Object (File)
Wed, Feb 26, 7:35 AM
Unknown Object (File)
Wed, Feb 26, 7:35 AM
Unknown Object (File)
Wed, Feb 26, 7:33 AM
Unknown Object (File)
Wed, Feb 26, 7:31 AM
Unknown Object (File)
Wed, Feb 26, 7:30 AM
Unknown Object (File)
Wed, Feb 26, 7:30 AM
Unknown Object (File)
Wed, Feb 26, 7:02 AM
Subscribers
None

Details

Summary

Ref PHI101. It looks like this was maybe copy/pasted by mistake in recent design refactoring.

We need to pass the full path, not the basename() of the path, to the search form.

Test Plan

Searched inside scripts/test/, found results inside scripts/test/.

Diff Detail

Repository
rP Phabricator
Branch
search1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18589
Build 25039: Run Core Tests
Build 25038: arc lint + arc unit