Paths

Table of Contentst

Correct bad context path when doing pattern search inside a repository
ClosedPublic
Actions

Authored by epriestley on Sep 29 2017, 9:50 PM.

Tags

None

Referenced Files

	F13171232: D18664.diff
	Tue, May 7, 10:09 AM

	F13169068: D18664.diff
	Tue, May 7, 8:10 AM

	Unknown Object (File)
	Sun, May 5, 9:18 AM

	Unknown Object (File)
	Fri, May 3, 7:51 AM

	Unknown Object (File)
	Sat, Apr 27, 3:51 AM

	Unknown Object (File)
	Thu, Apr 25, 1:48 AM

	Unknown Object (File)
	Tue, Apr 16, 7:51 PM

	Unknown Object (File)
	Tue, Apr 16, 7:51 PM

View All 74 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPa39f5e11139a: Correct bad context path when doing pattern search inside a repository

Summary

Ref PHI101. It looks like this was maybe copy/pasted by mistake in recent design refactoring.

We need to pass the full path, not the basename() of the path, to the search form.

Test Plan

Searched inside scripts/test/, found results inside scripts/test/.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 29 2017, 9:50 PM

Harbormaster completed remote builds in B18589: Diff 44810.Sep 29 2017, 9:50 PM

amckinley accepted this revision.Sep 29 2017, 9:51 PM

This revision is now accepted and ready to land.Sep 29 2017, 9:51 PM

Harbormaster completed remote builds in B18589: Diff 44810.Sep 29 2017, 9:51 PM

Closed by commit rPa39f5e11139a: Correct bad context path when doing pattern search inside a repository (authored by epriestley). · Explain WhySep 29 2017, 9:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionBrowseController.php

3 lines

Diff 44811

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Correct bad context path when doing pattern search inside a repositoryClosedPublicActions