Page MenuHomePhabricator

Modularize "arc lint" renderers
ClosedPublic

Authored by epriestley on Sep 25 2017, 9:48 PM.
Tags
None
Referenced Files
F22107702: D18645.id44784.diff
Fri, Aug 21, 5:01 PM
F22107670: D18645.id44764.diff
Fri, Aug 21, 4:59 PM
F22106851: D18645.diff
Fri, Aug 21, 4:26 PM
Unknown Object (File)
Tue, Aug 11, 2:01 PM
Unknown Object (File)
Sun, Aug 9, 6:33 AM
Unknown Object (File)
Jul 5 2026, 4:55 AM
Unknown Object (File)
Jul 2 2026, 5:28 AM
Unknown Object (File)
Jun 30 2026, 4:24 PM
Subscribers
None

Details

Summary

Ref T12996. arc lint can render in different formats with --output <format>.

Previously, these were a big switch() statement and a bunch of hard-coded stuff.

Modularize them so that that third parties could add new renderers, and this code can be refactored toward parallelizing the lint step.

This has a small behavioral change: we no longer hide "autofix" messages. I'd like to generally simplify the number of amend/autofix flags here, so this edges us toward that slightly.

Test Plan

Ran arc lint with all the --output flags in states with warnings and no warnings, saw sensible-seeming behavior.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable