Page MenuHomePhabricator

Modularize "arc lint" renderers
ClosedPublic

Authored by epriestley on Sep 25 2017, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 17, 2:11 PM
Unknown Object (File)
Tue, Sep 13, 12:17 PM
Unknown Object (File)
Thu, Sep 8, 2:20 PM
Unknown Object (File)
Wed, Sep 7, 12:55 PM
Unknown Object (File)
Mon, Sep 5, 9:06 AM
Unknown Object (File)
Aug 19 2022, 1:39 AM
Unknown Object (File)
Aug 15 2022, 6:02 PM
Unknown Object (File)
Aug 4 2022, 12:26 AM
Subscribers
None

Details

Summary

Ref T12996. arc lint can render in different formats with --output <format>.

Previously, these were a big switch() statement and a bunch of hard-coded stuff.

Modularize them so that that third parties could add new renderers, and this code can be refactored toward parallelizing the lint step.

This has a small behavioral change: we no longer hide "autofix" messages. I'd like to generally simplify the number of amend/autofix flags here, so this edges us toward that slightly.

Test Plan

Ran arc lint with all the --output flags in states with warnings and no warnings, saw sensible-seeming behavior.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable