Page MenuHomePhabricator

Modularize "arc lint" renderers
ClosedPublic

Authored by epriestley on Sep 25 2017, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 4:55 AM
Unknown Object (File)
Tue, Dec 17, 11:49 PM
Unknown Object (File)
Fri, Dec 13, 3:49 PM
Unknown Object (File)
Thu, Dec 12, 4:47 AM
Unknown Object (File)
Sat, Dec 7, 3:48 AM
Unknown Object (File)
Fri, Dec 6, 10:37 PM
Unknown Object (File)
Fri, Dec 6, 3:19 PM
Unknown Object (File)
Sat, Nov 30, 12:32 AM
Subscribers
None

Details

Summary

Ref T12996. arc lint can render in different formats with --output <format>.

Previously, these were a big switch() statement and a bunch of hard-coded stuff.

Modularize them so that that third parties could add new renderers, and this code can be refactored toward parallelizing the lint step.

This has a small behavioral change: we no longer hide "autofix" messages. I'd like to generally simplify the number of amend/autofix flags here, so this edges us toward that slightly.

Test Plan

Ran arc lint with all the --output flags in states with warnings and no warnings, saw sensible-seeming behavior.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable