Page MenuHomePhabricator

Modularize "arc lint" renderers
ClosedPublic

Authored by epriestley on Sep 25 2017, 9:48 PM.
Tags
None
Referenced Files
F18030268: D18645.diff
Sat, Aug 2, 11:34 PM
F17986856: D18645.id.diff
Fri, Aug 1, 9:52 PM
F17942917: D18645.diff
Thu, Jul 31, 7:21 AM
Unknown Object (File)
Jun 3 2025, 7:39 PM
Unknown Object (File)
Jun 3 2025, 7:36 PM
Unknown Object (File)
May 28 2025, 8:14 PM
Unknown Object (File)
May 27 2025, 7:23 AM
Unknown Object (File)
Apr 29 2025, 5:58 PM
Subscribers
None

Details

Summary

Ref T12996. arc lint can render in different formats with --output <format>.

Previously, these were a big switch() statement and a bunch of hard-coded stuff.

Modularize them so that that third parties could add new renderers, and this code can be refactored toward parallelizing the lint step.

This has a small behavioral change: we no longer hide "autofix" messages. I'd like to generally simplify the number of amend/autofix flags here, so this edges us toward that slightly.

Test Plan

Ran arc lint with all the --output flags in states with warnings and no warnings, saw sensible-seeming behavior.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable