Page MenuHomePhabricator

Modularize "arc lint" renderers
ClosedPublic

Authored by epriestley on Sep 25 2017, 9:48 PM.
Tags
None
Referenced Files
F18874640: D18645.id44784.diff
Wed, Nov 5, 3:23 PM
F18872738: D18645.id44764.diff
Wed, Nov 5, 6:00 AM
F18865270: D18645.id44764.diff
Mon, Nov 3, 11:33 AM
F18858300: D18645.diff
Sat, Nov 1, 9:47 PM
F18765534: D18645.id44784.diff
Oct 7 2025, 11:44 AM
F18742567: D18645.id.diff
Oct 2 2025, 8:17 PM
F18736270: D18645.diff
Oct 1 2025, 5:18 AM
F18653000: D18645.diff
Sep 21 2025, 10:31 AM
Subscribers
None

Details

Summary

Ref T12996. arc lint can render in different formats with --output <format>.

Previously, these were a big switch() statement and a bunch of hard-coded stuff.

Modularize them so that that third parties could add new renderers, and this code can be refactored toward parallelizing the lint step.

This has a small behavioral change: we no longer hide "autofix" messages. I'd like to generally simplify the number of amend/autofix flags here, so this edges us toward that slightly.

Test Plan

Ran arc lint with all the --output flags in states with warnings and no warnings, saw sensible-seeming behavior.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable