Page MenuHomePhabricator

Modularize "arc lint" renderers
ClosedPublic

Authored by epriestley on Sep 25 2017, 9:48 PM.
Tags
None
Referenced Files
F15407815: D18645.diff
Tue, Mar 18, 7:46 PM
F15398456: D18645.id44784.diff
Mon, Mar 17, 12:09 AM
F15397085: D18645.diff
Sun, Mar 16, 6:04 PM
Unknown Object (File)
Mon, Feb 24, 1:01 AM
Unknown Object (File)
Feb 18 2025, 4:25 AM
Unknown Object (File)
Feb 12 2025, 10:08 PM
Unknown Object (File)
Jan 21 2025, 12:53 PM
Unknown Object (File)
Jan 21 2025, 9:52 AM
Subscribers
None

Details

Summary

Ref T12996. arc lint can render in different formats with --output <format>.

Previously, these were a big switch() statement and a bunch of hard-coded stuff.

Modularize them so that that third parties could add new renderers, and this code can be refactored toward parallelizing the lint step.

This has a small behavioral change: we no longer hide "autofix" messages. I'd like to generally simplify the number of amend/autofix flags here, so this edges us toward that slightly.

Test Plan

Ran arc lint with all the --output flags in states with warnings and no warnings, saw sensible-seeming behavior.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable