Paths

Table of Contentst

Differential D18632

Don't show a blank line if there is no user data
ClosedPublic
Actions

Authored by alexmv on Sep 20 2017, 9:35 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCe88a8c077b33: (stable) Promote 2017 Week 38
rARCc804c5026011: Don't show a blank line if there is no user data

Summary

SKIP lines, for instance, often have no UserData; there is no
reason to display a content-less blank line.

Test Plan

arc unit

Diff Detail

Repository

rARC Arcanist

Branch

blank-line (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18509
Build 24928: Run Core Tests
Build 24927: arc lint + arc unit

Event Timeline

alexmv created this revision.Sep 20 2017, 9:35 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 20 2017, 9:35 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B18509: Diff 44732.Sep 20 2017, 9:35 PM

Prefer a strlen() test over a plain test, so values like "0", "0.0", etc., are printed faithfully.

This revision now requires changes to proceed.Sep 20 2017, 9:43 PM

Swap to a strlen, instead of using truthiness

Herald added a subscriber: Korvin. · View Herald TranscriptSep 21 2017, 12:44 AM

Harbormaster completed remote builds in B18513: Diff 44735.Sep 21 2017, 12:44 AM

epriestley accepted this revision.Sep 21 2017, 12:44 AM

This revision is now accepted and ready to land.Sep 21 2017, 12:44 AM

Closed by commit rARCc804c5026011: Don't show a blank line if there is no user data (authored by alexmv). · Explain WhySep 21 2017, 12:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

unit/

renderer/

ArcanistUnitConsoleRenderer.php

3 lines

Diff 44732

View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

Don't show a blank line if there is no user dataClosedPublicActions