Page MenuHomePhabricator

Don't show a blank line if there is no user data
ClosedPublic

Authored by alexmv on Sep 20 2017, 9:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 1:07 PM
Unknown Object (File)
Fri, Mar 15, 11:46 PM
Unknown Object (File)
Sat, Mar 9, 2:36 AM
Unknown Object (File)
Feb 3 2024, 4:57 PM
Unknown Object (File)
Dec 27 2023, 12:10 PM
Unknown Object (File)
Dec 27 2023, 12:10 PM
Unknown Object (File)
Dec 27 2023, 12:10 PM
Unknown Object (File)
Dec 27 2023, 12:10 PM
Subscribers

Details

Summary

SKIP lines, for instance, often have no UserData; there is no
reason to display a content-less blank line.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Prefer a strlen() test over a plain test, so values like "0", "0.0", etc., are printed faithfully.

This revision now requires changes to proceed.Sep 20 2017, 9:43 PM

Swap to a strlen, instead of using truthiness

This revision is now accepted and ready to land.Sep 21 2017, 12:44 AM
This revision was automatically updated to reflect the committed changes.