Page MenuHomePhabricator

Fix an error in Diffusion when the Owners application is uninstalled
ClosedPublic

Authored by epriestley on Sep 19 2017, 4:23 PM.
Tags
None
Referenced Files
F19943322: D18629.diff
Thu, Apr 16, 2:41 AM
F19802578: D18629.id44724.diff
Mar 1 2026, 5:38 PM
F19534914: D18629.id.diff
Jan 21 2026, 3:21 AM
F19032003: D18629.diff
Nov 25 2025, 4:03 AM
F18891790: D18629.id.diff
Nov 7 2025, 11:03 AM
F18866955: D18629.diff
Nov 3 2025, 8:29 PM
F18685527: D18629.id.diff
Sep 26 2025, 11:16 AM
F18679373: D18629.diff
Sep 26 2025, 12:47 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/undefined-view-when-owners-is-uninstalled/451.

When Owners is not installed, Diffusion can fatal with a bad $view.

Test Plan
  • Uninstall Owners.
  • View the content of any file in Diffusion.
  • Before: fatal on $view undefined.
  • After: Valid page with no owners information.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18500
Build 24915: Run Core Tests
Build 24914: arc lint + arc unit