Page MenuHomePhabricator

Create revisions into "Draft", publish them when builds finish
ClosedPublic

Authored by epriestley on Sep 18 2017, 11:01 PM.
Tags
None
Referenced Files
F13078783: D18628.id44740.diff
Tue, Apr 23, 6:44 PM
F13078782: D18628.id44723.diff
Tue, Apr 23, 6:44 PM
F13078781: D18628.id44722.diff
Tue, Apr 23, 6:44 PM
F13078780: D18628.id.diff
Tue, Apr 23, 6:44 PM
F13078779: D18628.diff
Tue, Apr 23, 6:44 PM
Unknown Object (File)
Sun, Apr 21, 7:38 PM
Unknown Object (File)
Fri, Apr 19, 6:50 PM
Unknown Object (File)
Sun, Apr 7, 7:12 PM
Subscribers
None

Details

Summary

Ref T2543. This doesn't stand alone since mail still goes out normally, but gets this piece working: new revisions start as "Draft", then after updates if there are no builds they go into "Needs Review".

This should work in general because builds update revisions when they complete, to publish a "Harbormaster finished build yada yada" transaction. So either we'll un-draft immediately, or un-draft after the last build finishes.

I'll hold this until the mail and some other stuff (like UI hints) are in slightly better shape since I think it's probably too rough on its own.

Test Plan

Created revisions locally, saw them un-draft after builds.

Diff Detail

Repository
rP Phabricator
Branch
draft4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18499
Build 24913: Run Core Tests
Build 24912: arc lint + arc unit