Fix credential control logic for restricted credentials
ClosedPublic
Actions

Authored by epriestley on Sep 5 2017, 6:34 PM.

Tags

None

Referenced Files

	F14083258: D18537.id44511.diff
	Sat, Nov 23, 3:32 AM

	Unknown Object (File)
	Wed, Nov 20, 8:27 PM

	Unknown Object (File)
	Sat, Nov 16, 3:47 PM

	Unknown Object (File)
	Thu, Nov 14, 4:46 AM

	Unknown Object (File)
	Tue, Nov 12, 1:07 PM

	Unknown Object (File)
	Tue, Nov 12, 12:05 PM

	Unknown Object (File)
	Tue, Nov 12, 10:08 AM

	Unknown Object (File)
	Tue, Nov 12, 7:10 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12975: Unable to update Credential on URI when credential policy is set to other user

Commits

rP89a70bf56c93: (stable) Fix credential control logic for restricted credentials
rPd5ba30c777f4: Fix credential control logic for restricted credentials

Summary

Fixes T12975. This logic didn't deal with PolicyException correctly.

Test Plan

Screen Shot 2017-09-05 at 11.33.00 AM.png (1×1 px, 187 KB)

Diff Detail

Repository

rP Phabricator

Branch

cred1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18290
Build 24611: Run Core Tests
Build 24610: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 5 2017, 6:34 PM

Harbormaster completed remote builds in B18290: Diff 44508.Sep 5 2017, 6:35 PM

chad accepted this revision.Sep 5 2017, 6:50 PM

This revision is now accepted and ready to land.Sep 5 2017, 6:50 PM

Closed by commit rPd5ba30c777f4: Fix credential control logic for restricted credentials (authored by epriestley). · Explain WhySep 5 2017, 6:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

view/

PassphraseCredentialControl.php

34 lines

Diff 44508

View Options

src/applications/passphrase/view/PassphraseCredentialControl.php

Fix credential control logic for restricted credentialsClosedPublicActions