Page MenuHomePhabricator
Differential D18511

Restore the caret pointer ("^") for lint lines which only have a character offset
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 7:38 PM.
Tags
None
Referenced Files
F15436852: D18511.id44460.diff
Tue, Mar 25, 4:40 PM
F15436553: D18511.id44465.diff
Tue, Mar 25, 3:06 PM
F15435459: D18511.diff
Tue, Mar 25, 8:26 AM
F15433828: D18511.id.diff
Tue, Mar 25, 12:45 AM
F15432108: D18511.id44465.diff
Mon, Mar 24, 4:09 PM
F15427725: D18511.diff
Sun, Mar 23, 3:48 PM
F15426346: D18511.id.diff
Sun, Mar 23, 8:05 AM
F15425494: D18511.id44460.diff
Sun, Mar 23, 4:48 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC213ed3ff15d7: Restore the caret pointer ("^") for lint lines which only have a character…
Summary

Ref T9846. This was dropped when I refactored how things are rendered; restore it.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
ldisplay4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18244
Build 24538: Run Core Tests
Build 24537: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
11 lines
__tests__/
7 lines
data/
11 lines
4 lines

Diff 44460

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/caret.expect

Loading...
View Options

src/lint/renderer/__tests__/data/caret.txt

Loading...
Phabricator · Built by Phacility