Page MenuHomePhabricator
Differential D18511

Restore the caret pointer ("^") for lint lines which only have a character offset
ClosedPublic
Actions

Authored by epriestley on Aug 31 2017, 7:38 PM.
Tags
None
Referenced Files
F15381172: D18511.id44460.diff
Fri, Mar 14, 6:15 AM
F15367873: D18511.id44460.diff
Tue, Mar 11, 9:37 PM
Unknown Object (File)
Thu, Feb 20, 10:50 PM
Unknown Object (File)
Feb 11 2025, 11:35 PM
Unknown Object (File)
Feb 11 2025, 11:07 PM
Unknown Object (File)
Feb 11 2025, 10:59 PM
Unknown Object (File)
Feb 11 2025, 10:50 PM
Unknown Object (File)
Feb 11 2025, 3:55 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9846: Diff on `arc lint` misleading when the replacement has newlines
Commits
rARC213ed3ff15d7: Restore the caret pointer ("^") for lint lines which only have a character…
Summary

Ref T9846. This was dropped when I refactored how things are rendered; restore it.

Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
ldisplay4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18244
Build 24538: Run Core Tests
Build 24537: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
11 lines
__tests__/
7 lines
data/
11 lines
4 lines

Diff 44460

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/caret.expect

Loading...
View Options

src/lint/renderer/__tests__/data/caret.txt

Loading...
Phabricator · Built by Phacility