Page MenuHomePhabricator

Separate saved queries in applications into "personal" and "global" queries
ClosedPublic

Authored by epriestley on Aug 14 2017, 8:15 PM.
Tags
None
Referenced Files
F15453653: D18426.id44277.diff
Sat, Mar 29, 1:25 PM
F15452963: D18426.id44366.diff
Sat, Mar 29, 8:26 AM
F15451713: D18426.id.diff
Fri, Mar 28, 11:29 PM
F15444056: D18426.diff
Thu, Mar 27, 7:34 AM
Unknown Object (File)
Mar 3 2025, 6:09 AM
Unknown Object (File)
Feb 26 2025, 9:01 AM
Unknown Object (File)
Feb 26 2025, 1:16 AM
Unknown Object (File)
Feb 24 2025, 7:55 PM
Subscribers
None

Details

Summary

Ref T12956. UI changes:

  • Administrators get a new [X] Save as global query option when saving a query.
  • "Edit Queries..." is split into "Personal" and "Global" sections. For administrators, each section can be edited. For non-admins, only the top section can be edited, but any query can be pinned.

A couple notes:

  • This doesn't support "pin for everyone by default". New users just get the first query from the bottom set. That seems reasonable for now.
  • Reordering is currently a little buggy (it works if you've reordered before, but not if you're reordering for the first time), but I need to migrate before I can fix / test that properly. So that'll get cleaned up in the next change or two.
Test Plan
  • As an admin and non-admin, viewed, edited, disabled, saved-as-personal and saved-as-global various queries.

Screen Shot 2017-08-14 at 1.12.32 PM.png (758×1 px, 104 KB)

Screen Shot 2017-08-14 at 1.11.45 PM.png (970×1 px, 153 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable