Page MenuHomePhabricator

Separate saved queries in applications into "personal" and "global" queries

Authored by epriestley on Aug 14 2017, 8:15 PM.
Referenced Files
Unknown Object (File)
Thu, Nov 30, 12:09 AM
Unknown Object (File)
Sat, Nov 25, 4:07 PM
Unknown Object (File)
Wed, Nov 15, 5:23 AM
Unknown Object (File)
Mon, Nov 13, 5:43 AM
Unknown Object (File)
Oct 27 2023, 9:08 AM
Unknown Object (File)
Oct 17 2023, 6:59 PM
Unknown Object (File)
Sep 22 2023, 6:40 AM
Unknown Object (File)
Sep 17 2023, 12:48 AM



Ref T12956. UI changes:

  • Administrators get a new [X] Save as global query option when saving a query.
  • "Edit Queries..." is split into "Personal" and "Global" sections. For administrators, each section can be edited. For non-admins, only the top section can be edited, but any query can be pinned.

A couple notes:

  • This doesn't support "pin for everyone by default". New users just get the first query from the bottom set. That seems reasonable for now.
  • Reordering is currently a little buggy (it works if you've reordered before, but not if you're reordering for the first time), but I need to migrate before I can fix / test that properly. So that'll get cleaned up in the next change or two.
Test Plan
  • As an admin and non-admin, viewed, edited, disabled, saved-as-personal and saved-as-global various queries.

Screen Shot 2017-08-14 at 1.12.32 PM.png (758×1 px, 104 KB)

Screen Shot 2017-08-14 at 1.11.45 PM.png (970×1 px, 153 KB)

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable