Page MenuHomePhabricator

Provide some more detailed information about inline comments in "transaction.search"
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:19 PM.
Tags
None
Referenced Files
F21407775: D18469.id44372.diff
Wed, Jul 29, 10:02 AM
F21406122: D18469.diff
Wed, Jul 29, 9:09 AM
Unknown Object (File)
Jun 28 2026, 6:50 AM
Unknown Object (File)
Jun 22 2026, 3:27 PM
Unknown Object (File)
Apr 2 2026, 5:10 AM
Unknown Object (File)
Feb 15 2026, 2:01 PM
Unknown Object (File)
Jan 19 2026, 9:54 PM
Unknown Object (File)
Jan 19 2026, 6:43 PM
Subscribers
None

Details

Summary

Ref T5873. This provides paths and line numbers for inline comments.

This is a touch hacky but I was able to keep it mostly under control.

Test Plan
  • Made inline comments.
  • Called API, got path/line information.

Screen Shot 2017-08-24 at 3.14.22 PM.png (508×631 px, 90 KB)

Diff Detail

Repository
rP Phabricator
Branch
xaction4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18151
Build 24400: Run Core Tests
Build 24399: arc lint + arc unit