Page MenuHomePhabricator

Provide some more detailed information about inline comments in "transaction.search"
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:19 PM.
Tags
None
Referenced Files
F17869511: D18469.id.diff
Mon, Jul 28, 11:31 AM
F17862556: D18469.id44364.diff
Mon, Jul 28, 12:03 AM
F17625520: D18469.diff
Thu, Jul 10, 3:18 AM
Unknown Object (File)
Jun 28 2025, 10:01 PM
Unknown Object (File)
Jun 17 2025, 11:13 AM
Unknown Object (File)
Jun 4 2025, 9:42 AM
Unknown Object (File)
Jun 3 2025, 3:03 PM
Unknown Object (File)
Jun 2 2025, 11:18 AM
Subscribers
None

Details

Summary

Ref T5873. This provides paths and line numbers for inline comments.

This is a touch hacky but I was able to keep it mostly under control.

Test Plan
  • Made inline comments.
  • Called API, got path/line information.

Screen Shot 2017-08-24 at 3.14.22 PM.png (508×631 px, 90 KB)

Diff Detail

Repository
rP Phabricator
Branch
xaction4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18151
Build 24400: Run Core Tests
Build 24399: arc lint + arc unit