Page MenuHomePhabricator

Provide some more detailed information about inline comments in "transaction.search"
ClosedPublic

Authored by epriestley on Aug 24 2017, 10:19 PM.
Tags
None
Referenced Files
F15089779: D18469.diff
Mon, Feb 17, 8:00 AM
Unknown Object (File)
Tue, Jan 21, 4:02 PM
Unknown Object (File)
Tue, Jan 21, 10:00 AM
Unknown Object (File)
Jan 18 2025, 1:22 AM
Unknown Object (File)
Jan 16 2025, 10:54 PM
Unknown Object (File)
Dec 27 2024, 6:26 PM
Unknown Object (File)
Dec 24 2024, 2:27 PM
Unknown Object (File)
Dec 22 2024, 2:14 AM
Subscribers
None

Details

Summary

Ref T5873. This provides paths and line numbers for inline comments.

This is a touch hacky but I was able to keep it mostly under control.

Test Plan
  • Made inline comments.
  • Called API, got path/line information.

Screen Shot 2017-08-24 at 3.14.22 PM.png (508×631 px, 90 KB)

Diff Detail

Repository
rP Phabricator
Branch
xaction4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18151
Build 24400: Run Core Tests
Build 24399: arc lint + arc unit