Fixes T10964. This check if a branch is being tracked before deciding to show information. This feels a little janky, but works OK.
Details
Details
- Reviewers
chad - Maniphest Tasks
- T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it
Set Track Only to stable, with master set to default.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- untracked (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 18092 Build 24308: Run Core Tests Build 24307: arc lint + arc unit
Event Timeline
| src/applications/diffusion/controller/DiffusionRepositoryController.php | ||
|---|---|---|
| 65 | I think this if statement is never hit. Unsure what the intent of the task was, maybe this case is not possible. | |
Comment Actions
Can you cover these cases in your test plan?
- Create a new repository, immediately set it to track only stable before activating it, activate it, view main page.
- View a branch which does not exist, and is tracked.
- View a branch which does not exist, and is not tracked.
- View a branch which exists, and is tracked.
- Delete a tracked branch, then view it in the web UI.
- Close a branch in Mercurial, then view it.
Comment Actions
Create a new repository, immediately set it to track only stable before activating it, activate it, view main page.
Uhhhhhhhhh
Comment Actions
- I think this is all correct, but some outlier bugs in HG and shouldTrack are tripping me up