Page MenuHomePhabricator

Show error message in Diffusion if branch is not tracked
AbandonedPublic

Authored by epriestley on Aug 17 2017, 4:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 20, 3:52 PM
Unknown Object (File)
Feb 16 2024, 9:30 AM
Unknown Object (File)
Feb 8 2024, 4:49 PM
Unknown Object (File)
Feb 6 2024, 12:27 AM
Unknown Object (File)
Feb 3 2024, 4:29 PM
Unknown Object (File)
Jan 31 2024, 11:02 AM
Unknown Object (File)
Jan 14 2024, 2:13 PM
Unknown Object (File)
Jan 7 2024, 4:58 PM
Subscribers

Details

Summary

Fixes T10964. This check if a branch is being tracked before deciding to show information. This feels a little janky, but works OK.

Test Plan

Set Track Only to stable, with master set to default.

image.png (1×2 px, 142 KB)

Diff Detail

Repository
rP Phabricator
Branch
untracked (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18094
Build 24312: Run Core Tests
Build 24311: arc lint + arc unit

Event Timeline

src/applications/diffusion/controller/DiffusionRepositoryController.php
64

I think this if statement is never hit. Unsure what the intent of the task was, maybe this case is not possible.

Can you cover these cases in your test plan?

  • Create a new repository, immediately set it to track only stable before activating it, activate it, view main page.
  • View a branch which does not exist, and is tracked.
  • View a branch which does not exist, and is not tracked.
  • View a branch which exists, and is tracked.
  • Delete a tracked branch, then view it in the web UI.
  • Close a branch in Mercurial, then view it.

Create a new repository, immediately set it to track only stable before activating it, activate it, view main page.

Uhhhhhhhhh

I guess this is more than UI changes.

  • just pushing changes, then abandoning
chad planned changes to this revision.Aug 17 2017, 6:19 PM
  • I think this is all correct, but some outlier bugs in HG and shouldTrack are tripping me up
epriestley abandoned this revision.
epriestley edited reviewers, added: chad; removed: epriestley.

Mooted by context changes in T10964.