Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
F21201144: D18419.id44254.diff
Sun, Jul 5, 6:58 AM
Unknown Object (File)
Fri, Jul 3, 12:16 AM
Unknown Object (File)
Mon, Jun 22, 5:07 PM
Unknown Object (File)
Mar 5 2026, 12:57 PM
Unknown Object (File)
Mar 3 2026, 9:17 PM
Unknown Object (File)
Feb 9 2026, 4:17 PM
Unknown Object (File)
Dec 10 2025, 9:34 PM
Unknown Object (File)
Dec 2 2025, 11:14 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable