Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
F15812049: D18419.diff
Fri, May 30, 2:38 PM
Unknown Object (File)
Thu, May 29, 7:35 AM
Unknown Object (File)
Wed, May 28, 6:19 PM
Unknown Object (File)
Mon, May 5, 9:58 PM
Unknown Object (File)
Mon, May 5, 5:01 AM
Unknown Object (File)
Mon, May 5, 5:01 AM
Unknown Object (File)
Mon, May 5, 5:01 AM
Unknown Object (File)
Mon, May 5, 4:35 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Branch
status20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18046
Build 24242: Run Core Tests
Build 24241: arc lint + arc unit