Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 4:13 PM
Unknown Object (File)
Mon, Mar 4, 8:23 PM
Unknown Object (File)
Feb 1 2024, 11:08 PM
Unknown Object (File)
Jan 31 2024, 9:20 AM
Unknown Object (File)
Jan 10 2024, 4:51 PM
Unknown Object (File)
Jan 5 2024, 1:41 PM
Unknown Object (File)
Dec 27 2023, 11:52 AM
Unknown Object (File)
Dec 27 2023, 11:52 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Branch
status20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18046
Build 24242: Run Core Tests
Build 24241: arc lint + arc unit