Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 10:08 AM
Unknown Object (File)
Wed, Apr 10, 9:34 PM
Unknown Object (File)
Wed, Apr 10, 8:28 PM
Unknown Object (File)
Wed, Apr 10, 8:11 PM
Unknown Object (File)
Wed, Apr 10, 6:08 PM
Unknown Object (File)
Mon, Apr 8, 6:58 PM
Unknown Object (File)
Mon, Apr 8, 8:00 AM
Unknown Object (File)
Sat, Apr 6, 8:58 PM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable