Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
F17862198: D18419.diff
Sun, Jul 27, 11:39 PM
F17849729: D18419.id.diff
Sun, Jul 27, 9:02 AM
F17842996: D18419.id44254.diff
Sun, Jul 27, 12:21 AM
F17840956: D18419.id44263.diff
Sat, Jul 26, 9:44 PM
F17816888: D18419.diff
Fri, Jul 25, 11:10 PM
Unknown Object (File)
Sun, Jun 29, 7:52 AM
Unknown Object (File)
Sat, Jun 28, 6:17 PM
Unknown Object (File)
Jun 3 2025, 2:55 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable