Page MenuHomePhabricator

Move all revision status transactions to modern values and mechanics
ClosedPublic

Authored by epriestley on Aug 12 2017, 12:03 AM.
Tags
None
Referenced Files
F15505305: D18419.id44254.diff
Tue, Apr 15, 1:59 AM
F15451980: D18419.id44254.diff
Sat, Mar 29, 12:58 AM
F15417300: D18419.id44263.diff
Mar 20 2025, 4:33 PM
F15400014: D18419.diff
Mar 17 2025, 9:05 AM
F15388758: D18419.id44263.diff
Mar 15 2025, 4:21 AM
F15386638: D18419.diff
Mar 15 2025, 1:00 AM
F15367587: D18419.id44263.diff
Mar 11 2025, 8:00 PM
F15337613: D18419.diff
Mar 9 2025, 6:42 AM
Subscribers
None

Details

Summary

Ref T2543. This updates and migrates the status change transactions:

  • All storage now records the modern modular transaction ("differential.revision.status"), not the obsolete non-modular transaction ("differential:status").
  • All storage now records the modern constants ("accepted"), not the obsolete numeric values ("2").
Test Plan
  • Selected all the relevant rows before/after migration, data looked sane.
  • Browsed around, reviewed timelines, no changes after migration.
  • Changed revision states, saw appropriate new transactions in the database and timeline rendering.
  • Grepped for differential:status.

Diff Detail

Repository
rP Phabricator
Branch
status20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18046
Build 24242: Run Core Tests
Build 24241: arc lint + arc unit