Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 9:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 1, 4:53 PM
Unknown Object (File)
Sat, May 31, 11:01 AM
Unknown Object (File)
Sat, May 31, 10:28 AM
Unknown Object (File)
Thu, May 29, 6:59 AM
Unknown Object (File)
Sat, May 10, 12:13 AM
Unknown Object (File)
Mon, May 5, 4:35 AM
Unknown Object (File)
Apr 29 2025, 10:17 AM
Unknown Object (File)
Apr 28 2025, 4:21 PM
Subscribers
None

Details

Summary

Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

Repository
rP Phabricator
Branch
status12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18036
Build 24223: Run Core Tests
Build 24222: arc lint + arc unit