Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 9:39 PM.
Tags
None
Referenced Files
F19284404: D18410.diff
Dec 23 2025, 5:26 AM
F19059635: D18410.diff
Nov 29 2025, 6:21 AM
F18799992: D18410.diff
Oct 17 2025, 3:44 PM
F18759498: D18410.id44255.diff
Oct 6 2025, 4:12 AM
F18508996: D18410.id.diff
Sep 5 2025, 3:09 AM
F18501408: D18410.diff
Sep 4 2025, 9:44 PM
F18094883: D18410.id.diff
Aug 7 2025, 10:24 PM
F18089175: D18410.id44255.diff
Aug 6 2025, 10:35 AM
Subscribers
None

Details

Summary

Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

Repository
rP Phabricator
Branch
status12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18036
Build 24223: Run Core Tests
Build 24222: arc lint + arc unit