Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 9:39 PM.
Tags
None
Referenced Files
F15467239: D18410.id44255.diff
Thu, Apr 3, 1:50 PM
F15454681: D18410.id44244.diff
Sat, Mar 29, 7:46 PM
F15444065: D18410.diff
Thu, Mar 27, 7:38 AM
F15423300: D18410.id.diff
Sat, Mar 22, 2:36 PM
F15416811: D18410.id44255.diff
Thu, Mar 20, 1:40 PM
F15332716: D18410.diff
Fri, Mar 7, 7:28 PM
F15283402: D18410.id44255.diff
Mar 4 2025, 7:11 AM
Unknown Object (File)
Feb 26 2025, 2:49 AM
Subscribers
None

Details

Summary

Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable