Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 9:39 PM.
Tags
None
Referenced Files
F13148642: D18410.id.diff
Sat, May 4, 3:13 AM
Unknown Object (File)
Fri, May 3, 9:30 AM
Unknown Object (File)
Thu, Apr 25, 3:09 AM
Unknown Object (File)
Fri, Apr 19, 6:43 PM
Unknown Object (File)
Sat, Apr 6, 9:31 PM
Unknown Object (File)
Apr 1 2024, 6:15 AM
Unknown Object (File)
Mar 30 2024, 4:57 AM
Unknown Object (File)
Mar 26 2024, 8:32 AM
Subscribers
None

Details

Summary

Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable