Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 9:39 PM.
Tags
None
Referenced Files
F14731856: D18410.diff
Sat, Jan 18, 11:30 AM
F14730628: D18410.diff
Sat, Jan 18, 7:36 AM
Unknown Object (File)
Sun, Jan 12, 9:57 PM
Unknown Object (File)
Fri, Dec 27, 2:08 PM
Unknown Object (File)
Dec 17 2024, 10:09 PM
Unknown Object (File)
Dec 12 2024, 5:48 PM
Unknown Object (File)
Dec 5 2024, 6:46 PM
Unknown Object (File)
Nov 27 2024, 1:58 AM
Subscribers
None

Details

Summary

Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

Repository
rP Phabricator
Branch
status12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18036
Build 24223: Run Core Tests
Build 24222: arc lint + arc unit