Page MenuHomePhabricator

Modularize the Differential "status" transaction and move away from ArcanistDifferentialRevisionStatus
ClosedPublic

Authored by epriestley on Aug 11 2017, 9:39 PM.
Tags
None
Referenced Files
F21204800: D18410.id44255.diff
Sun, Jul 5, 9:45 AM
F21203929: D18410.diff
Sun, Jul 5, 8:52 AM
Unknown Object (File)
Sat, Jul 4, 7:12 AM
Unknown Object (File)
Sat, Jul 4, 3:02 AM
Unknown Object (File)
Wed, Jul 1, 10:56 AM
Unknown Object (File)
Dec 23 2025, 5:26 AM
Unknown Object (File)
Nov 29 2025, 6:21 AM
Unknown Object (File)
Oct 17 2025, 3:44 PM
Subscribers
None

Details

Summary

Ref T2543. Converts the TYPE_STATUS transaction (used to render "This revision now requires changes to proceed.", "This revision is accepted and ready to land.", etc) to ModularTransactions.

Also, continue consolidating all the status-related information (here, more colors and icons) into a single place. By the end of this, we may learn that NEEDS_REVIEW uses every color.

Test Plan

Reviewed old status transactions (unchanged) and created new ones (looked the same as the old ones).

(I plan to migrate all of these a few diffs from now, around when I change the storage format.)

Diff Detail

Repository
rP Phabricator
Branch
status12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18036
Build 24223: Run Core Tests
Build 24222: arc lint + arc unit