Page MenuHomePhabricator

Reduce STATUS_CLOSED (now internally "Published") revision status callsites
ClosedPublic

Authored by epriestley on Aug 4 2017, 3:23 PM.
Tags
None
Referenced Files
F15381790: D18341.diff
Fri, Mar 14, 9:21 AM
Unknown Object (File)
Mon, Mar 3, 7:16 AM
Unknown Object (File)
Feb 2 2025, 3:52 PM
Unknown Object (File)
Jan 23 2025, 11:15 PM
Unknown Object (File)
Jan 21 2025, 9:34 AM
Unknown Object (File)
Jan 18 2025, 2:14 PM
Unknown Object (File)
Jan 17 2025, 3:12 PM
Unknown Object (File)
Jan 17 2025, 8:46 AM
Subscribers
None

Details

Summary

Ref T2543. Add isPublished() to mean: exactly the status 'closed', which is now interally called 'published', but still shown as 'closed' to users.

We have some callsites which are about "exactly that status", vs "any 'closed' status", e.g. including "abandoned".

This also introduces isChangePlanned(), which felt less awkward than isChangesPlanned() but more consistent than hasChangesPlanned() or isStatusChangesPlanned() or similar.

Test Plan

grep, loaded revisions, requested review.

Diff Detail

Repository
rP Phabricator
Branch
status3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17909
Build 24052: Run Core Tests
Build 24051: arc lint + arc unit