Page MenuHomePhabricator

Reduce STATUS_CLOSED (now internally "Published") revision status callsites
ClosedPublic

Authored by epriestley on Aug 4 2017, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 11:27 PM
Unknown Object (File)
Mon, Apr 22, 10:47 PM
Unknown Object (File)
Fri, Apr 19, 6:41 PM
Unknown Object (File)
Tue, Apr 16, 5:59 PM
Unknown Object (File)
Sat, Apr 6, 9:40 PM
Unknown Object (File)
Apr 3 2024, 3:52 AM
Unknown Object (File)
Mar 30 2024, 4:52 AM
Unknown Object (File)
Mar 29 2024, 10:07 PM
Subscribers
None

Details

Summary

Ref T2543. Add isPublished() to mean: exactly the status 'closed', which is now interally called 'published', but still shown as 'closed' to users.

We have some callsites which are about "exactly that status", vs "any 'closed' status", e.g. including "abandoned".

This also introduces isChangePlanned(), which felt less awkward than isChangesPlanned() but more consistent than hasChangesPlanned() or isStatusChangesPlanned() or similar.

Test Plan

grep, loaded revisions, requested review.

Diff Detail

Repository
rP Phabricator
Branch
status3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17909
Build 24052: Run Core Tests
Build 24051: arc lint + arc unit