In Differential, filter repository operations to just "Land" operations again
ClosedPublic
Actions

Authored by epriestley on Jul 26 2017, 5:11 PM.

Details

Reviewers

Commits

rPe47f85cd98b8: In Differential, filter repository operations to just "Land" operations again

Summary

Reverts D18276. See PHI18 for discussion. The additional rules here (roughly, "only show the first successful operation") didn't actually work out for the other types of operations.

This is all just figuring out a stopgap, T12935 and other changes should eventually provide real pathways here.

Test Plan

Straight revert.

Diff Detail

Repository

rP Phabricator

Branch

landfilter

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17809
Build 23918: Run Core Tests
Build 23917: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 26 2017, 5:11 PM

Harbormaster completed remote builds in B17809: Diff 43966.Jul 26 2017, 5:11 PM

Harbormaster completed remote builds in B17809: Diff 43966.

chad accepted this revision.Jul 26 2017, 6:03 PM

This revision is now accepted and ready to land.Jul 26 2017, 6:03 PM

Closed by commit rPe47f85cd98b8: In Differential, filter repository operations to just "Land" operations again (authored by epriestley, committed by epriestley). · Explain WhyJul 26 2017, 6:51 PM

This revision was automatically updated to reflect the committed changes.

See PHI18 for discussion

Is it expected that Community members can't see this object?

Yes

Ok thanks

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

8 lines

Diff 43966

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

In Differential, filter repository operations to just "Land" operations againClosedPublicActions