Differential D18276

In Differential, render status for any active Drydock repository operation, not just "Land" operations
ClosedPublic
Actions

Authored by epriestley on Jul 25 2017, 1:56 PM.

Tags

None

Referenced Files

	F18348198: D18276.diff
	Tue, Aug 26, 4:26 PM

	F18115152: D18276.diff
	Wed, Aug 13, 6:26 AM

	F18099728: D18276.id43958.diff
	Sat, Aug 9, 8:09 AM

	F18099407: D18276.id43955.diff
	Sat, Aug 9, 4:41 AM

	F18099044: D18276.diff
	Sat, Aug 9, 12:56 AM

	F18098881: D18276.id.diff
	Fri, Aug 8, 11:34 PM

	F18098287: D18276.id43958.diff
	Fri, Aug 8, 7:26 PM

	F18087071: D18276.id43955.diff
	Wed, Aug 6, 2:10 AM

Subscribers

None

Details

Reviewers

Commits

rP1588d3e224fe: In Differential, render status for any active Drydock repository operation, not…

Summary

See PHI18. Third parties can currently define other types of Drydock operations (like "Merge Check" or "Cherry-Pick") but we won't show them in the UI.

This is a simple change which improves third-party support for now. These kinds of operations generally make sense in the upstream, but the pathways to support are longer.

Test Plan

Verified that there are no other types of repository operation which we'd want to exclude in the upstream today by reviewing the "Repository Operation" subclasses.
Will click some buttons in production to make sure this works.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jul 25 2017, 1:56 PM

Harbormaster completed remote builds in B17800: Diff 43955.Jul 25 2017, 1:57 PM

chad accepted this revision.Jul 25 2017, 4:21 PM

This revision is now accepted and ready to land.Jul 25 2017, 4:21 PM

Closed by commit rP1588d3e224fe: In Differential, render status for any active Drydock repository operation, not… (authored by epriestley, committed by epriestley). · Explain WhyJul 25 2017, 4:55 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18281: In Differential, filter repository operations to just "Land" operations again.Jul 26 2017, 5:11 PM

epriestley mentioned this in rPe47f85cd98b8: In Differential, filter repository operations to just "Land" operations again.Jul 26 2017, 6:51 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

8 lines

Diff 43958

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...