Restore "Land Revision" action to UI
ClosedPublic
Actions

Authored by epriestley on Jun 26 2017, 1:46 PM.

Tags

None

Referenced Files

	F15465994: D18154.id43680.diff
	Thu, Apr 3, 12:42 AM

	F15461789: D18154.id.diff
	Tue, Apr 1, 11:17 AM

	F15459862: D18154.diff
	Mon, Mar 31, 5:30 PM

	F15458350: D18154.id43679.diff
	Sun, Mar 30, 11:11 PM

	F15456968: D18154.diff
	Sun, Mar 30, 1:24 PM

	F15426337: D18154.diff
	Sun, Mar 23, 8:03 AM

	F15333764: D18154.diff
	Sat, Mar 8, 4:40 AM

	Unknown Object (File)
	Feb 22 2025, 6:50 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rP7cb67dc7257e: (stable) Restore "Land Revision" action to UI
rPd4632f4b78a0: Restore "Land Revision" action to UI

Summary

This was accidentally caught in the crossfire in D18150. This is stable enough to formalize instead of adding with an event hook.

Test Plan

Looked at a candidate revision, saw "Land Revision" appear in UI again.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 26 2017, 1:46 PM

chad accepted this revision.Jun 26 2017, 1:47 PM

This revision is now accepted and ready to land.Jun 26 2017, 1:47 PM

Harbormaster completed remote builds in B17569: Diff 43679.Jun 26 2017, 1:48 PM

Closed by commit rPd4632f4b78a0: Restore "Land Revision" action to UI (authored by epriestley, committed by epriestley). · Explain WhyJun 26 2017, 1:50 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP219ae8b6c950: Remove old "Landing Strategy" code.Jun 26 2017, 1:51 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

23 lines

Diff 43680

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Restore "Land Revision" action to UIClosedPublicActions