Restore "Land Revision" action to UI
ClosedPublic
Actions

Authored by epriestley on Jun 26 2017, 1:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 17, 3:21 PM

	Unknown Object (File)
	Thu, Apr 11, 7:28 AM

	Unknown Object (File)
	Fri, Apr 5, 11:44 PM

	Unknown Object (File)
	Mon, Apr 1, 3:41 AM

	Unknown Object (File)
	Thu, Mar 28, 7:56 AM

	Unknown Object (File)
	Feb 21 2024, 9:12 AM

	Unknown Object (File)
	Feb 21 2024, 7:45 AM

	Unknown Object (File)
	Feb 13 2024, 6:29 PM

View All 89 Files

Subscribers

None

Details

Reviewers

chad

Commits

rP7cb67dc7257e: (stable) Restore "Land Revision" action to UI
rPd4632f4b78a0: Restore "Land Revision" action to UI

Summary

This was accidentally caught in the crossfire in D18150. This is stable enough to formalize instead of adding with an event hook.

Test Plan

Looked at a candidate revision, saw "Land Revision" appear in UI again.

Diff Detail

Repository

rP Phabricator

Branch

land1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17569
Build 23575: Run Core Tests
Build 23574: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 26 2017, 1:46 PM

chad accepted this revision.Jun 26 2017, 1:47 PM

This revision is now accepted and ready to land.Jun 26 2017, 1:47 PM

Harbormaster completed remote builds in B17569: Diff 43679.Jun 26 2017, 1:48 PM

Closed by commit rPd4632f4b78a0: Restore "Land Revision" action to UI (authored by epriestley, committed by epriestley). · Explain WhyJun 26 2017, 1:50 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rP219ae8b6c950: Remove old "Landing Strategy" code.Jun 26 2017, 1:51 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

23 lines

Diff 43679

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Restore "Land Revision" action to UIClosedPublicActions