Page MenuHomePhabricator

Fix ambiguous URI parsing in Youtube Remarkup rule
ClosedPublic

Authored by epriestley on Jun 23 2017, 2:37 PM.
Tags
None
Referenced Files
F15409895: D18149.diff
Wed, Mar 19, 5:51 AM
F15391919: D18149.id43671.diff
Sat, Mar 15, 12:22 PM
F15385262: D18149.id43671.diff
Fri, Mar 14, 10:06 PM
F15338887: D18149.id43671.diff
Sun, Mar 9, 1:19 PM
F15302848: D18149.diff
Wed, Mar 5, 10:53 PM
F15283401: D18149.id43671.diff
Tue, Mar 4, 7:11 AM
Unknown Object (File)
Thu, Feb 27, 5:49 AM
Unknown Object (File)
Fri, Feb 21, 4:20 PM
Subscribers
None

Details

Summary

Fixes T12867. Also:

  • Simplify the code a little.
  • Stop mutating this on text/mobile -- there's no inherent value in the "youtu.be" link so I think this just changes the text the user wrote unnecessarily.
Test Plan

Screen Shot 2017-06-23 at 7.32.50 AM.png (552×1 px, 395 KB)

Diff Detail

Repository
rP Phabricator
Branch
youtube1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17556
Build 23558: Run Core Tests
Build 23557: arc lint + arc unit