Page MenuHomePhabricator

Improve validation errors for changing task priorities
ClosedPublic

Authored by epriestley on Jun 19 2017, 7:40 PM.
Tags
None
Referenced Files
F18094751: D18135.diff
Thu, Aug 7, 10:19 PM
F17935292: D18135.diff
Jul 30 2025, 11:17 PM
F17932179: D18135.id43638.diff
Jul 30 2025, 7:49 PM
F17868495: D18135.diff
Jul 28 2025, 7:51 AM
F17859579: D18135.id43634.diff
Jul 27 2025, 8:53 PM
Unknown Object (File)
Jun 18 2025, 1:42 PM
Unknown Object (File)
Jun 17 2025, 10:58 PM
Unknown Object (File)
Jun 15 2025, 10:17 PM
Subscribers
None

Details

Summary

Ref T12124. Currently, Conduit provides a fairly rough error message if you provide an invalid priority.

Instead, provide a more tailored message. Also, block !!unknown!! except from web edits.

Test Plan

Before:

Screen Shot 2017-06-19 at 12.33.57 PM.png (1×1 px, 186 KB)

After:

Screen Shot 2017-06-19 at 12.36.52 PM.png (1×1 px, 192 KB)

Also, changed a priority to 999 in the database, edited it with the normal web UI form, it let me make the edit without being forced to adjust the priority.

Diff Detail

Repository
rP Phabricator
Branch
form2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17526
Build 23512: Run Core Tests
Build 23511: arc lint + arc unit