Page MenuHomePhabricator
Differential D18116

Add profile images to Repositories
ClosedPublic
Actions

Authored by chad on Jun 12 2017, 3:31 AM.
Tags
None
Referenced Files
F13145315: D18116.diff
Fri, May 3, 8:54 AM
F13136691: D18116.id43578.diff
Thu, May 2, 3:10 PM
Unknown Object (File)
Sat, Apr 27, 4:26 AM
Unknown Object (File)
Sat, Apr 27, 12:16 AM
Unknown Object (File)
Thu, Apr 25, 3:53 AM
Unknown Object (File)
Thu, Apr 25, 2:42 AM
Unknown Object (File)
Fri, Apr 19, 6:36 PM
Unknown Object (File)
Thu, Apr 18, 2:26 PM
View All 91 Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12825: Allow setting of an image per repository
Commits
rP83a89166ee33: Add profile images to Repositories
Summary

Builds out some images to use to identify repositories. Fixes T12825.

Test Plan

Try setting custom, built in, and null images.

image.png (782×978 px, 75 KB)

image.png (552×924 px, 75 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad created this revision.Jun 12 2017, 3:31 AM
Herald added a subscriber: Korvin. · View Herald TranscriptJun 12 2017, 3:31 AM
Harbormaster failed remote builds in B17476: Diff 43578!Jun 12 2017, 3:33 AM
chad edited the test plan for this revision. (Show Details)Jun 12 2017, 3:33 AM
chad updated this revision to Diff 43579.Jun 12 2017, 3:35 AM
  • fix failing harbormaster build
Harbormaster completed remote builds in B17477: Diff 43579.Jun 12 2017, 3:36 AM
chad edited the test plan for this revision. (Show Details)Jun 12 2017, 3:41 AM
epriestley accepted this revision.Jun 12 2017, 2:14 PM

Are there license issues with these? They're from GitHub's icons, right?

This revision is now accepted and ready to land.Jun 12 2017, 2:14 PM
chad added a comment.Jun 12 2017, 2:18 PM

3 of the icons are, https://github.com/primer/octicons/blob/master/LICENSE

Do we need to add a license somewhere for dirivitive?

epriestley added a comment.Jun 12 2017, 2:19 PM

Maybe just put externals/octicons/ with the README and LICENSE?

Closed by commit rP83a89166ee33: Add profile images to Repositories (authored by chad, committed by chad). · Explain WhyJun 12 2017, 2:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43581

View Options

externals/octicons/LICENSE

Loading...
View Options

externals/octicons/README.md

Loading...
View Options

resources/builtin/repo/building.png

Loading...
View Options

resources/builtin/repo/cloud.png

Loading...
View Options

resources/builtin/repo/code.png

Loading...
View Options

resources/builtin/repo/commit.png

Loading...
View Options

resources/builtin/repo/database.png

Loading...
View Options

resources/builtin/repo/desktop.png

Loading...
View Options

resources/builtin/repo/gears.png

Loading...
View Options

resources/builtin/repo/globe.png

Loading...
View Options

resources/builtin/repo/locked.png

Loading...
View Options

resources/builtin/repo/microchip.png

Loading...
View Options

resources/builtin/repo/mobile.png

Loading...
View Options

resources/builtin/repo/repo.png

Loading...
View Options

resources/builtin/repo/servers.png

Loading...
View Options

resources/sql/autopatches/20170612.repository.image.01.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryProfilePictureController.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility