Page MenuHomePhabricator

Add profile images to Repositories
ClosedPublic

Authored by chad on Jun 12 2017, 3:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 27, 4:04 AM
Unknown Object (File)
Mon, Mar 27, 2:08 AM
Unknown Object (File)
Sun, Mar 26, 12:29 AM
Unknown Object (File)
Fri, Mar 3, 1:16 AM
Unknown Object (File)
Feb 27 2023, 11:04 AM
Unknown Object (File)
Feb 18 2023, 6:40 AM
Unknown Object (File)
Jan 25 2023, 6:10 PM
Unknown Object (File)
Dec 17 2022, 5:26 AM
Subscribers

Details

Summary

Builds out some images to use to identify repositories. Fixes T12825.

Test Plan

Try setting custom, built in, and null images.

image.png (782×978 px, 75 KB)

image.png (552×924 px, 75 KB)

Diff Detail

Repository
rP Phabricator
Branch
diff-profile-image (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17477
Build 23436: Run Core Tests
Build 23435: arc lint + arc unit

Event Timeline

  • fix failing harbormaster build

Are there license issues with these? They're from GitHub's icons, right?

This revision is now accepted and ready to land.Jun 12 2017, 2:14 PM

3 of the icons are, https://github.com/primer/octicons/blob/master/LICENSE

Do we need to add a license somewhere for dirivitive?

Maybe just put externals/octicons/ with the README and LICENSE?

This revision was automatically updated to reflect the committed changes.