Builds out some images to use to identify repositories. Fixes T12825.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12825: Allow setting of an image per repository
- Commits
- rP83a89166ee33: Add profile images to Repositories
Try setting custom, built in, and null images.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- diff-profile-image (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 17476 Build 23434: Run Core Tests Build 23433: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 227 ms | PhabricatorChangeParserTestCase::Unknown Unit Message (" ") EXCEPTION (Exception): Builtin "repository/repository1.png" does not exist!
#0 /core/data/drydock/workingcopy-70/repo/phabricator/src/applications/files/storage/PhabricatorFile.php(1117): PhabricatorFilesOnDiskBuiltinFile->loadBuiltinFileData()
#1 /core/data/drydock/workingcopy-70/repo/phabricator/src/applications/files/storage/PhabricatorFile.php(1167): PhabricatorFile::loadBuiltins(Object(PhabricatorUser), Array)
| |
| 1 ms | AlmanacNamesTestCase::Unknown Unit Message (" ") 30 assertions passed. | |
| 0 ms | AlmanacServiceTypeTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| 1 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 1 assertion passed. | |
| 0 ms | AphrontHTTPSinkTestCase::Unknown Unit Message (" ") 3 assertions passed. | |
| View Full Test Results (1 Failed · 355 Passed) |
Event Timeline
Comment Actions
3 of the icons are, https://github.com/primer/octicons/blob/master/LICENSE
Do we need to add a license somewhere for dirivitive?