Page MenuHomePhabricator

Give "x committed <commit>" feed stories an explicitly higher action strength than other transactions
ClosedPublic

Authored by epriestley on Jun 8 2017, 12:45 PM.
Tags
None
Referenced Files
F15453503: D18104.id43561.diff
Sat, Mar 29, 12:16 PM
F15452106: D18104.id43551.diff
Sat, Mar 29, 1:50 AM
F15451758: D18104.diff
Fri, Mar 28, 11:40 PM
F15447096: D18104.id.diff
Thu, Mar 27, 9:49 PM
F15441169: D18104.diff
Wed, Mar 26, 4:47 PM
F15435544: D18104.diff
Tue, Mar 25, 8:50 AM
F15424839: D18104.id43561.diff
Sun, Mar 23, 12:25 AM
F15421805: D18104.id43551.diff
Sat, Mar 22, 2:18 AM
Subscribers
None

Details

Summary

Fixes T12811. The issue here appears to be that both the "alice committed rXYZabc" and "Herald added projects..." actions have the same (default) strength and end up applying in arbitrary order, and probably got shuffled around as this transitioned to Modular transactions.

Give "alice committed rXYZabc" an explicitly higher action strength.

Test Plan
  • Wrote an "Always, add project X" Herald rule for commits.
  • Ran bin/repository reparse --herald ....
  • Saw an "alice committed rXYZabc" story instead of a "Herald added projects: X" story.

Diff Detail

Repository
rP Phabricator
Branch
feed1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17448
Build 23390: Run Core Tests
Build 23389: arc lint + arc unit