Page MenuHomePhabricator

Give "x committed <commit>" feed stories an explicitly higher action strength than other transactions
ClosedPublic

Authored by epriestley on Jun 8 2017, 12:45 PM.
Tags
None
Referenced Files
F13135432: D18104.diff
Thu, May 2, 8:43 AM
Unknown Object (File)
Mon, Apr 29, 2:52 PM
Unknown Object (File)
Wed, Apr 24, 10:50 PM
Unknown Object (File)
Tue, Apr 2, 1:17 PM
Unknown Object (File)
Mar 6 2024, 4:28 AM
Unknown Object (File)
Feb 21 2024, 10:56 AM
Unknown Object (File)
Feb 21 2024, 8:11 AM
Unknown Object (File)
Feb 12 2024, 9:44 AM
Subscribers
None

Details

Summary

Fixes T12811. The issue here appears to be that both the "alice committed rXYZabc" and "Herald added projects..." actions have the same (default) strength and end up applying in arbitrary order, and probably got shuffled around as this transitioned to Modular transactions.

Give "alice committed rXYZabc" an explicitly higher action strength.

Test Plan
  • Wrote an "Always, add project X" Herald rule for commits.
  • Ran bin/repository reparse --herald ....
  • Saw an "alice committed rXYZabc" story instead of a "Herald added projects: X" story.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable