Page MenuHomePhabricator

Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransaction
ClosedPublic

Authored by epriestley on Jun 1 2017, 3:20 PM.
Tags
None
Referenced Files
F19940013: D18059.id43436.diff
Tue, Apr 14, 8:55 PM
F19937127: D18059.diff
Sun, Apr 12, 7:00 PM
F19814106: D18059.diff
Mar 4 2026, 12:41 PM
F19524048: D18059.id.diff
Jan 17 2026, 9:46 PM
F19524047: D18059.id.diff
Jan 17 2026, 9:46 PM
F19399047: D18059.id43436.diff
Dec 27 2025, 11:40 AM
F19312599: D18059.id43436.diff
Dec 25 2025, 12:31 AM
F18846401: D18059.diff
Oct 29 2025, 6:45 PM
Subscribers
None

Details

Summary

See D18018. Ref T12787. This doesn't actually work; we started publishing these stories as a side effect of converting to ModularTransactions, then I fixed the rendering.

This mechanism has very few callsites and I suspect we may want to get rid of it (see T12787) so just keep publishing these stories for now.

Test Plan

Changed the point value of a task, saw a feed story both before and after the patch.

Diff Detail

Repository
rP Phabricator
Branch
sub2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17349
Build 23252: Run Core Tests
Build 23251: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 1 2017, 4:09 PM
This revision was automatically updated to reflect the committed changes.