Paths

Table of Contentst

Differential D18018

Restore missing feed rendering for Maniphest points transactions
ClosedPublic
Actions

Authored by epriestley on May 25 2017, 8:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 30, 2:22 AM

	Unknown Object (File)
	Tue, Jan 28, 2:39 AM

	Unknown Object (File)
	Tue, Jan 28, 2:39 AM

	Unknown Object (File)
	Tue, Jan 28, 2:39 AM

	Unknown Object (File)
	Sat, Jan 25, 2:48 PM

	Unknown Object (File)
	Fri, Jan 24, 9:19 PM

	Unknown Object (File)
	Fri, Jan 24, 9:19 PM

	Unknown Object (File)
	Fri, Jan 24, 9:18 PM

Subscribers

None

Details

Reviewers

Commits

rP84742a94db13: Restore missing feed rendering for Maniphest points transactions

Summary

See downstream https://phabricator.wikimedia.org/T166321. These got dropped in refactoring, or maybe never existed.

Test Plan

Screen Shot 2017-05-25 at 1.03.20 PM.png (412×543 px, 56 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 25 2017, 8:04 PM

Harbormaster completed remote builds in B17250: Diff 43338.May 25 2017, 8:05 PM

Pretty sure never existed.

This revision is now accepted and ready to land.May 25 2017, 8:32 PM

Closed by commit rP84742a94db13: Restore missing feed rendering for Maniphest points transactions (authored by epriestley, committed by epriestley). · Explain WhyMay 25 2017, 9:26 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T12787: Creating a subtask 'reopens' the new task.Jun 1 2017, 3:14 PM

T12787 shed some light on this: previously, we used shouldHideFromFeed() to hide these stories completely.

ManiphestTaskPointsTransaction faithfully ported this over, but it doesn't currently work in ModularTransactions, so the previously hidden stories became visible.

I could go either way on continuing to publish these. I'm just going to leave them for the moment (and remove the inoperative shouldHideForFeed()) but we could completely hide them again in the future if they turn out to be too noisy.

epriestley mentioned this in D18059: Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransaction.Jun 1 2017, 3:20 PM

epriestley mentioned this in rPb69174a4c8f7: Remove non-operational `shouldHideFromFeed()` from….Jun 1 2017, 4:14 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

xaction/

ManiphestTaskPointsTransaction.php

26 lines

Diff 43342

src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php

Loading...