Page MenuHomePhabricator
Differential D18059

Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransaction
ClosedPublic
Actions

Authored by epriestley on Jun 1 2017, 3:20 PM.
Tags
None
Referenced Files
F16502984: D18059.diff
Mon, Jun 16, 7:52 PM
Unknown Object (File)
Sat, May 31, 10:57 AM
Unknown Object (File)
May 8 2025, 7:23 AM
Unknown Object (File)
May 7 2025, 6:55 PM
Unknown Object (File)
Apr 26 2025, 9:33 AM
Unknown Object (File)
Apr 22 2025, 7:27 AM
Unknown Object (File)
Apr 16 2025, 12:14 PM
Unknown Object (File)
Apr 8 2025, 8:03 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T12787: Creating a subtask 'reopens' the new task
Commits
rPb69174a4c8f7: Remove non-operational `shouldHideFromFeed()` from…
Summary

See D18018. Ref T12787. This doesn't actually work; we started publishing these stories as a side effect of converting to ModularTransactions, then I fixed the rendering.

This mechanism has very few callsites and I suspect we may want to get rid of it (see T12787) so just keep publishing these stories for now.

Test Plan

Changed the point value of a task, saw a feed story both before and after the patch.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 1 2017, 3:20 PM
Harbormaster completed remote builds in B17349: Diff 43436.Jun 1 2017, 3:21 PM
chad accepted this revision.Jun 1 2017, 4:09 PM
This revision is now accepted and ready to land.Jun 1 2017, 4:09 PM
Closed by commit rPb69174a4c8f7: Remove non-operational `shouldHideFromFeed()` from… (authored by epriestley, committed by epriestley). · Explain WhyJun 1 2017, 4:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
xaction/
4 lines

Diff 43437

View Options

src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php

Loading...
Phabricator · Built by Phacility