Differential D18059

Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransaction
ClosedPublic
Actions

Authored by epriestley on Jun 1 2017, 3:20 PM.

Details

Reviewers

chad

Maniphest Tasks

T12787: Creating a subtask 'reopens' the new task

Commits

rPb69174a4c8f7: Remove non-operational `shouldHideFromFeed()` from…

Summary

See D18018. Ref T12787. This doesn't actually work; we started publishing these stories as a side effect of converting to ModularTransactions, then I fixed the rendering.

This mechanism has very few callsites and I suspect we may want to get rid of it (see T12787) so just keep publishing these stories for now.

Test Plan

Changed the point value of a task, saw a feed story both before and after the patch.

Diff Detail

Repository

rP Phabricator

Branch

sub2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 17349
Build 23252: Run Core Tests
Build 23251: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 1 2017, 3:20 PM

Harbormaster completed remote builds in B17349: Diff 43436.Jun 1 2017, 3:21 PM

chad accepted this revision.Jun 1 2017, 4:09 PM

This revision is now accepted and ready to land.Jun 1 2017, 4:09 PM

Closed by commit rPb69174a4c8f7: Remove non-operational `shouldHideFromFeed()` from… (authored by epriestley, committed by epriestley). · Explain WhyJun 1 2017, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

xaction/

ManiphestTaskPointsTransaction.php

4 lines

Diff 43436

View Options

src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php

Remove non-operational `shouldHideFromFeed()` from ManiphestTaskPointsTransactionClosedPublicActions