Page MenuHomePhabricator
Differential D212

Fix daemon issues caused by Ubuntu's surprising intermediary shell
ClosedPublic
Actions

Authored by epriestley on May 2 2011, 4:56 PM.
Tags
None
Referenced Files
F14076872: D212.diff
Thu, Nov 21, 8:02 PM
F14076714: D212.diff
Thu, Nov 21, 7:27 PM
F14074089: D212.diff
Thu, Nov 21, 3:58 AM
Unknown Object (File)
Wed, Nov 20, 10:20 PM
Unknown Object (File)
Mon, Nov 18, 3:28 PM
Unknown Object (File)
Fri, Nov 15, 9:09 AM
Unknown Object (File)
Wed, Nov 13, 10:33 PM
Unknown Object (File)
Sun, Nov 10, 3:44 PM
View All Files
Subscribers
• briany12
dheerendra
lwjchaos
satbirjhuti
• sunzhen
• sunzhen1991
• WouterSioen
• young_hwi
Tokens
"Like" token, awarded by underyx."Like" token, awarded by davidme."Baby Tequila" token, awarded by floo51."Evil Spooky Haunted Tree" token, awarded by heinzbeinz."Like" token, awarded by test13254."The World Burns" token, awarded by eric.summers."Orange Medal" token, awarded by rohan03ace."Like" token, awarded by demo."Piece of Eight" token, awarded by jamesmarrone3."Like" token, awarded by adil.atilgan."Love" token, awarded by Magicfuture."Baby Tequila" token, awarded by karan.kanwar."Doubloon" token, awarded by joostfaassen."Yellow Medal" token, awarded by rmatrono."Like" token, awarded by jasdeep."Pterodactyl" token, awarded by sandro.giessl."The World Burns" token, awarded by chad."Like" token, awarded by shochdoerfer."Evil Spooky Haunted Tree" token, awarded by JimLiu."Love" token, awarded by bvb."Like" token, awarded by owenchu."The World Burns" token, awarded by yccheok."Like" token, awarded by jk."Baby Tequila" token, awarded by srodal.

Details

Reviewers
None
Commits
rPHU3721204cc896: Fix daemon issues caused by Ubuntu's surprising intermediary shell
Summary

On OSX and other Linuxii, proc_open('./exec_daemon ...') opens a PHP process; on Ubuntu it opens a "sh -c" process which opens a PHP process. The existence of this surprising shell made everything stop working.

Use 'exec' to replace the shell with the PHP process.

Test Plan

Ran daemons on OSX and Ubuntu, behavior seems okay in all cases.

Keep in mind I have absolutely no idea how Lunix works so this probably breaks the world. (cc: simpkins)

Diff Detail

Branch
master
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
• demo added a comment.Feb 23 2013, 10:39 AM

clowncopterize??!?

akopanev added a comment.Mar 6 2013, 9:30 AM

Just tested phabricator,
LGTM

src/daemon/overseer/PhutilDaemonOverseer.php
20

Yes, comments are good!
Testing phabricator....

142

testing...

• demo added a comment.Mar 25 2013, 5:50 AM

mmh

a.veretennikov added inline comments.Apr 9 2013, 11:42 AM
src/daemon/overseer/PhutilDaemonOverseer.php
26–36

Hello world! :)

a.veretennikov added a comment.Apr 9 2013, 1:30 PM

test

• g.albeniz added a comment.Apr 14 2013, 11:14 PM

kj

galetzka.michael added inline comments.Apr 15 2013, 8:58 AM
src/daemon/overseer/PhutilDaemonOverseer.php
148

test reply

• 113madixing2 added a comment.Apr 19 2013, 9:24 PM

test

src/daemon/overseer/PhutilDaemonOverseer.php
136–141

ggg

• _bhaisaab added inline comments.Apr 21 2013, 4:12 PM
src/daemon/overseer/PhutilDaemonOverseer.php
26–34

this works, why private, mutable states oh!

• jamiro added a comment.May 7 2013, 12:59 PM

test

Fabian added a comment.May 15 2013, 1:12 PM

The Future is ready

slmcygh added a comment.May 25 2013, 10:21 AM

test

hisaltesse added a comment.Jun 21 2013, 4:06 AM

asdf

• sharatjy added a comment.Jun 22 2013, 6:18 AM

asdsadl;lkadlalsjda

src/daemon/overseer/PhutilDaemonOverseer.php
135

fswfksjflksdjf

165

kkk

• michael.zhou added a comment.Jun 29 2013, 3:20 PM

test

• michael.zhou added a reviewer: michael.anthon.Jun 29 2013, 3:20 PM

test

zhangthe9 added a reviewer: ddallala.Jul 7 2013, 1:37 PM
• eboto added a comment.Jul 13 2013, 6:38 AM

I want everyone to welcome me to the peanut gallery.

sudharsans added a comment.Jul 15 2013, 11:17 AM

Testing.. line number 170 on left not correct

• lakshmy added a comment.Jul 15 2013, 11:38 PM

fdfdfdfdfdffdfdfdfdfdfdfdfdfdfddfdfdfadfad

• snogaraleal added a comment.Aug 3 2013, 2:58 AM

asdf

• RadeoslawPL added a comment.Aug 4 2013, 11:44 AM

nice

src/daemon/overseer/PhutilDaemonOverseer.php
184

Last line test

ulziibay added a comment.Aug 5 2013, 8:43 PM

{highlight=25} hello

ulziibay added a comment.Aug 5 2013, 8:45 PM

{D123, lines=124}

src/daemon/overseer/PhutilDaemonOverseer.php
185–187

Multiline comment shoo

niuyi added a comment.Aug 6 2013, 1:56 PM

test

• sbilstein added a comment.Aug 8 2013, 3:46 PM

testing

• kapiljainwal added a comment.Aug 20 2013, 6:38 AM

test comment

• adil.atilgan added a comment.Aug 21 2013, 2:24 PM

Thanks

src/daemon/overseer/PhutilDaemonOverseer.php
135

Seems like OK

• fajaven added a comment.Aug 24 2013, 3:51 AM

test comment

fabianbuch added inline comments.Aug 27 2013, 2:58 PM
src/daemon/overseer/PhutilDaemonOverseer.php
177–179
  • foo
  • bar
testleg added inline comments.Sep 12 2013, 9:46 AM
src/daemon/overseer/PhutilDaemonOverseer.php
184

I expect you also mean foo and bar as fabian suggested above... It's definitely safer to use foo but if you want it to run fast and you're not worried by the occasional fooble meltdown then you can use bar here too.

• jojofr added a comment.Sep 19 2013, 7:32 AM

Test Reply

• etnose added a reviewer: • etnose.Oct 28 2013, 12:35 AM
• amowu added a comment.Oct 29 2013, 4:34 PM

Hello world!

• lukianovva added inline comments.Nov 1 2013, 6:43 AM
src/daemon/overseer/PhutilDaemonOverseer.php
128

И придраться-то не к чему :)

• eep added inline comments.Nov 6 2013, 11:49 PM
src/daemon/overseer/PhutilDaemonOverseer.php
24

Good use of 'class' keyword

• eep added a comment.Nov 6 2013, 11:52 PM

Macro grumpy: above below

src/daemon/overseer/PhutilDaemonOverseer.php
24

Yep. Big fan.

• morgenroot added a comment.Nov 27 2013, 4:21 PM

Will the Future ever be ready?

shaneduffy added inline comments.Dec 20 2013, 1:34 PM
src/daemon/overseer/PhutilDaemonOverseer.php
133

Tihsihsidhs

134

testing

• JimJam added a comment.Dec 21 2013, 12:38 AM

Testing.

• JimJam added inline comments.Dec 21 2013, 12:39 AM
src/daemon/overseer/PhutilDaemonOverseer.php
195

Hit the road, buffers, and doncha come back no more, no more, no more, no more.

• dutta.deepanjan added a comment.Dec 21 2013, 4:14 AM

wow

tommycrush added inline comments.Dec 22 2013, 6:15 AM
src/daemon/overseer/PhutilDaemonOverseer.php
190–192

yay

201–203

gah

rmahasivabhattu added a comment.Dec 30 2013, 9:40 AM

adding a comment to test this demo

• test13254 added a comment.Jan 7 2014, 5:30 AM

There's too much purple in this codebase!

src/daemon/overseer/PhutilDaemonOverseer.php
24

Down with the Bourgeoisie class system!

• spanitz added a comment.Jan 8 2014, 3:31 PM

Missing @license tag in class comment (at line 17)

src/daemon/overseer/PhutilDaemonOverseer.php
154

Closing parenthesis of a multi-line function call must be on a line by itself (at line 89)

• manako added a comment.Jan 11 2014, 4:01 AM

Macro wizardhat: hello world not really.....going back to my cave now

src/daemon/overseer/PhutilDaemonOverseer.php
145

your comment is extremely helpful

sokabt added a reviewer: sokabt.Jan 11 2014, 6:43 PM

Why I eyes ya.

sunxboy added a comment.Jan 13 2014, 1:20 AM

test

• kriengpre added a comment.Jan 13 2014, 6:32 PM

Good

kvoell added a comment.Feb 13 2014, 1:50 PM

test

• louis-sherren added a comment.Feb 21 2014, 2:46 AM

test10

• louis-sherren added a comment.Feb 21 2014, 2:46 AM

test10

• louis-sherren added a comment.Feb 21 2014, 2:46 AM

test10

• louis-sherren added a comment.Feb 21 2014, 2:46 AM

test10

• louis-sherren added a comment.Feb 21 2014, 2:47 AM

test10

• louis-sherren added a comment.Feb 21 2014, 2:47 AM

test10

• louis-sherren added a comment.Feb 21 2014, 2:47 AM

test10

• louis-sherren added a comment.Feb 21 2014, 2:48 AM

test10

epriestley changed the visibility from "All Users" to "Public (No Login Required)".Mar 6 2014, 10:25 PM
floo51 awarded a token.Apr 23 2014, 7:50 AM
• davidme awarded a token.May 9 2014, 9:10 PM
• young_hwi added a subscriber: • young_hwi.Jun 11 2014, 1:55 AM
• underyx awarded a token.Sep 4 2014, 11:09 AM
avivey mentioned this in T6337: mentions don't show hovercards for logged-out users.Oct 16 2014, 9:37 PM
• sunzhen1991 added a subscriber: • sunzhen1991.Jan 6 2015, 7:29 AM

test

• sunzhen1991 added inline comments.Jan 6 2015, 7:36 AM
src/daemon/overseer/PhutilDaemonOverseer.php
43

test11

• WouterSioen added a subscriber: • WouterSioen.Mar 30 2015, 2:46 PM
• WouterSioen added inline comments.
src/daemon/overseer/PhutilDaemonOverseer.php
35

?

dheerendra added subscribers: • sunzhen, dheerendra.Apr 7 2015, 11:42 AM
dheerendra added inline comments.
src/daemon/overseer/PhutilDaemonOverseer.php
26–34

Re comment

29

I added this comment

31

My comment

43

I can reply too!!!!!!

44

@sunzhen How can I repy you

• briany12 added a subscriber: • briany12.Jun 18 2015, 10:25 PM
• briany12 added inline comments.
src/daemon/overseer/PhutilDaemonOverseer.php
24

inline comment.

satbirjhuti added a subscriber: satbirjhuti.Jul 31 2015, 8:33 PM
satbirjhuti added inline comments.
src/daemon/overseer/PhutilDaemonOverseer.php
137

MUCH ROOT! SUCH COMMENT!

lwjchaos added a subscriber: lwjchaos.Aug 3 2015, 10:06 AM
This comment was removed by lwjchaos.
avivey mentioned this in Z1336: General Chat.Aug 26 2015, 2:02 PM
avivey mentioned this in T13224: Pygments Bash lexer has explosive complexity on unterminated strings with many backslashes.Jan 28 2019, 11:24 PM

Revision Contents
Changeset List

PathSize
src/
daemon/
overseer/
16 lines

Diff 434

View Options

src/daemon/overseer/PhutilDaemonOverseer.php

Loading...
Phabricator · Built by Phacility